search

cosmology-tech / telescope

A TypeScript Transpiler for Cosmos Protobufs ⚛️
https://cosmology.zone/products/telescope
Apache License 2.0
141 stars 41 forks source link

some params not getting picked up #611

Open pyramation opened 2 months ago

pyramation commented 2 months ago

low priority, since it's mostly for LCD, which is technically deprecated

https://github.com/cosmology-tech/telescope/blob/85d83dc66d87ac9cc2890bc30c0b22c2d67d61c1/__fixtures__/osmojs/ibc-go/proto/ibc/applications/fee/v1/query.proto#L36-L39

https://github.com/cosmology-tech/telescope/blob/85d83dc66d87ac9cc2890bc30c0b22c2d67d61c1/__fixtures__/v-next/outputosmojs/ibc/applications/fee/v1/query.lcd.ts#L72-L74

Notice the _params thinks it's empty, but it's NOT:

 async totalAckFees(_params: QueryTotalAckFeesRequest = {}): Promise<QueryTotalAckFeesResponseSDKType> {
    const endpoint = `ibc/apps/fee/v1/channels/${params.packetId.channel_id}/ports/${params.packetId.port_id}/sequences/${params.packetId.sequence}/total_ack_fees`;
    return QueryTotalAckFeesResponse.fromSDKJSON(await this.req.get<QueryTotalAckFeesResponseSDKType>(endpoint));
  }
pyramation commented 2 months ago

I think the path info doesn't know how to deal with {package_id.chain_id} when creating path infos