search

cosmonic-labs / netreap

A Cilium controller implementation for Nomad
https://netreap.io
Apache License 2.0
130 stars 8 forks source link

Generate a static binary by disabling cgo #18

Closed deverton-godaddy closed 1 year ago

deverton-godaddy commented 1 year ago

As part of the Go 1.20 release it seems like the default for CGO_ENABLED is no longer carried over from the tools. This leads to linking issues on systems that use different versions of glibc from what the base image uses. See https://github.com/golang/go/issues/58550 for more details.

This change should fix #16

netlify[bot] commented 1 year ago

Deploy Preview for netreap canceled.

Name Link
Latest commit ded61cc455543bd22b79500205dd6c71d248bb1a
Latest deploy log https://app.netlify.com/sites/netreap/deploys/64c071d7f968860008d66c91
p1u3o commented 1 year ago

This also fixes Netreap on Rocky Linux 9 and I presume all other RHEL-9 based distros.

protochron commented 1 year ago

It looks like #21 supersedes this PR?

protochron commented 1 year ago

Ugh, realized I left review comments here instead of on #21. I'll copy them over to that one

deverton-godaddy commented 1 year ago

Argh, sorry, looks like I stuffed up the branches for the PR. Let me close this one in favor of #21