search

cosmonic-labs / netreap

A Cilium controller implementation for Nomad
https://netreap.io
Apache License 2.0
130 stars 8 forks source link

Add ability to specify list of ignored Nomad meta labels #46

Open kyern opened 1 month ago

kyern commented 1 month ago

Feature or Problem

We are actively using Nomad for developments and testing apps and push various deployment info to Nomad's meta such as time of deployment, author, pipeline id and other similar things that help to identify exact revision.
This leads to huge amount of unique labels on Cilium that creates new Identity for them exhausting free identities very fast.
New option provides ability to ignore specified metadata keys when Netreap labeling Cilium endpoints.

Related Issues

Consumer Impact

Can reduce amount of identities created by Cilium.
Without specifying any values Netreap behaviour won't change.

Testing

Built on platform(s)

Tested on platform(s)

Unit Test(s)

Manual Verification

Built changed version without new parameter/env var, deployed to Nomad. Behaviour didn't change. Specified some values for env var, that label absent from Cilium.

kyern commented 1 month ago

@protochron hi! Can you review please?