search

cosmos / b9-checkers-academy-draft

32 stars 41 forks source link

Incorrect MaxTurnDurationInSeconds constant naming #29

Closed aomerk closed 2 years ago

aomerk commented 2 years ago

To compute a game's deadline, we are giving it a default maximum duration of 24 hours, which is defined as:

    MaxTurnDurationInSeconds = time.Duration(24 * 3_600 * 1000_000_000) // 1 day

However, 24 * 3600 * 1e9 is a day in nanoseconds, I think we should rename:

MaxTurnDurationInSeconds to MaxTurnDuration

Since, A) It's actually nanoseconds B) Nanosecond unit is implied within the term Duration

xavierlepretre commented 2 years ago

Thank you.