search

cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
648 stars 333 forks source link

Multisignature in fail in Direct Sign Mode #1273

Open akkien opened 2 years ago

akkien commented 2 years ago

I create a new module using Ignite CLI that requires multi-signature. My module only has direct message types. So I copy file https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/multisignature.ts#L58 and create my own makeMultisignedTx with SignMode.SIGN_MODE_DIRECT, but it failed.

Right now I plan to create aminoType for my new message.

Is it possible to support multisignedTx in SIGN_MODE_DIRECT? Do you have a plan to add this into cosmjs?

webmaster128 commented 2 years ago

Sounds like a good addition. It is Amino JSON only right now because you need to know the sign mode of each signer in advance and this is typically used for supporting Ledger signing.

akkien commented 2 years ago

Thank you for your answer.

webmaster128 commented 2 years ago

Feel free to keep this open. We can add it if there are users who need it.