search

cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
650 stars 339 forks source link

Missing earliest block in RPC sync info #1448

Closed livthomas closed 1 year ago

livthomas commented 1 year ago

Cosmjs only parses the following fields from sync_info record returned by /status RPC method:

But there are also other fields present in sync_info which are not processed by cosmjs:

Steps to Reproduce

  1. Try to hit /status endpoint on any public RPC node (e.g. https://cosmos-rpc.rockrpc.net/status).
  2. See what fields are returned within result.sync_info.
  3. Look at RpcSyncInfo interface in both tendermint34 and tendermint37 adaptors.
webmaster128 commented 1 year ago

Thank you for bringing this up. Sounds like a straight forwards addition to the tendermint-rpc packet. Do you want to work on a PR for that?

livthomas commented 1 year ago

Yes, I'm already working on it.

webmaster128 commented 1 year ago

Done in #1449