search

cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
645 stars 330 forks source link

Add memo field to AminoMsgTransfer #1456

Closed shanev closed 11 months ago

shanev commented 1 year ago

This enables Packet Forwarding Middleware to work with IBC Hooks by adding a memo field to the IBC transfer message. As discussed in #1413 and based on work by @jhernandezb and @luke-ae.

webmaster128 commented 1 year ago

Diff LGTM. Unfortunately we cannot easily test it against a chain because simapp does not have IBC anymore.

Could you please allow modification from maintainers? Then I can add a CHANGELOG entry and merge.

webmaster128 commented 11 months ago

Ping

shanev commented 11 months ago

Diff LGTM. Unfortunately we cannot easily test it against a chain because simapp does not have IBC anymore.

Could you please allow modification from maintainers? Then I can add a CHANGELOG entry and merge.

Can you check now?

webmaster128 commented 10 months ago

Amino support for the MsgTransfer memo should work as of 0.31.3, released today. See https://github.com/cosmos/cosmjs/issues/1493 for an overview of the state of affairs.