search

cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
645 stars 330 forks source link

AminoMsgTransfer is not supporting Memo of the message #1461

Closed csplr closed 11 months ago

csplr commented 1 year ago

Can it be that the AminoMsgTransfer is not supporting the Memo field of the message?

https://github.com/cosmos/cosmjs/blob/358260bff71c9d3e7ad6644fcf64dc00325cdfb9/packages/stargate/src/modules/ibc/aminomessages.ts#L18

When the OfflineAminoSigner is used for example with a Ledger device, where in the Transfer Msg we also want to send a memo field, the memo gets discarded

webmaster128 commented 1 year ago

Right, thanks for bringing this up. The fix is here: https://github.com/cosmos/cosmjs/pull/1456

M-Picco commented 11 months ago

@webmaster128 Any chance of getting the mentioned fix merged? I've run into some issues with Ledger on both Keplr and Leap and I think this missing field in the encoding may be the root cause.

I noticed the PR has been inactive for some time. Need it be I can fork it and open a new PR.

webmaster128 commented 11 months ago

Right, let's wait a day or two for Shane. Otherwise I can create a new branch and merge it.