search

cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
645 stars 330 forks source link

Support for cosmos-sdk v0.50, TM 0.38 #1464

Closed Anmol1696 closed 1 year ago

Anmol1696 commented 1 year ago

Overview

Pre-release out for cosmos-sdk version v0.50, it would be really helpful if we can start adding support for TM 0.38 which will be used.

webmaster128 commented 1 year ago

In https://github.com/cosmos/cosmjs/pull/1466 I tried using the Tendermint 0.37 client for Comet BFT 0.38. But this does not seem to work. We need a separate 0.38 client. Once we have that, we can easily adapt the auto-detection.

Anmol1696 commented 1 year ago

Would it be similar to #1376?

webmaster128 commented 1 year ago

What needs to be done is this:

  1. Copy and commit the tendermint37 folder and Tendermint37Client into tendermint38 and Tendermint38Client. The diff should only be renamings here.
  2. Test the new client against the 0.38 backend (set up in #1466)
  3. Make all changes required to make tests pass
  4. Adapt the auto-selection in the higher level clients
webmaster128 commented 1 year ago

In #1466 we have Comet 0.38 support done