cosmos / cosmjs

The Swiss Army knife to power JavaScript based client solutions ranging from Web apps/explorers over browser extensions to server-side clients like faucets/scrapers.
https://cosmos.github.io/cosmjs/
Apache License 2.0
647 stars 332 forks source link

Can the verification of denom be rolled back? #1588

Open zakir-code opened 4 months ago

zakir-code commented 4 months ago

Hi

As an early user of cosmos-sdk, cosmos-sdk supports custom denom format verification rules. Please refer to https://github.com/cosmos/cosmos-sdk/blob/main/types/coin.go#L858. Just as cosmos-sdk supports custom address prefixes, I don't think it should be mandatory to verify the length of denom. This will reduce the compatibility of many products open to the cosmos ecosystem. This is not in line with cosmos's long-standing philosophy of openness and inclusiveness.

Ref: https://github.com/cosmos/cosmjs/commit/8ca4560b6e3a0703eb1a29098dfd6e5552e7bd34 Ref: https://github.com/cosmos/cosmjs/commits/main/packages/stargate/src/fee.spec.ts