Filter search results by version select

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

6.22k stars 3.59k forks source link

Filter search results by version select #15936

Closed rootulp closed 1 year ago

rootulp commented 1 year ago

Context

I'm trying to learn if transactions use legacy amino codec or non amino codec in Cosmos SDK v0.46. I'm on https://docs.cosmos.network/v0.46/ but when I search for Amino, all the results are for v0.45

julienrbrt commented 1 year ago

The version is displayed in the search result. I believe all the cosmos docs using this theme behave this way. Given that we have migrated to docusaurus and we do not really touch vuepress anymore, I wonder if this is beneficial looking into fixing this. Is it that much of an issue for you?

rootulp commented 1 year ago

I can work around it by finding the page I want from the v0.45 search results and then re-navigating there on the v0.46 docs so it's not that big of an issue.

I created an issue b/c I've found the search feature for the Cosmos SDK pretty difficult to use and this is another instance of friction.

tac0turtle commented 1 year ago

@samricotta is this fixed in the docs rewrite?

samricotta commented 1 year ago

@tac0turtle yep will be fixed by rewrite