[Bug]: ERROR: no Ledger discovery function defined on MacOS

[UniversalGlow]

Summary of Bug

Disclaimer: I sincerely hope I am posting this in the correct repo. This pertains the Binance CLI (bnbcli) specifically which is obviously built on Cosmos-SDK. I have already opened an issue on their repo (here > https://github.com/bnb-chain/node/issues/962) but thought I would hedge my bets on 2 horses (unsure if the bnb chain repo is very active). If still, this is misplaced, I apologise.

Bug Summary: Upon downloading the latest binary for MacOS (v10.4.0) from their repo anything interaction I try to do with my Ledger (Nano S) fails spitting out the following error: ERROR: no Ledger discovery function defined. A friend has exactly the same issue. v0.6.0 is the only version of bnbcli that does not have this issue and works with the Ledger just fine. I wonder if they included Ledger support in the most recent builds.

Version

10.4.0

Steps to Reproduce

• Download https://github.com/bnb-chain/node/releases/download/v0.10.14/macos_binary.zip
• Connect Ledger and open Binance Chain App
• try a very simple command to work with Ledger (eg: ./bnbcli keys add binance_keys --ledger --index 0 --account 0
• Output will immediately be : ERROR: no Ledger discovery function defined

[UniversalGlow]

After doing some more digging I guess the issue is as stated in a 2018 changelog:

LEDGER_ENABLED true by default except when cross-compiling

So I built from code now and already got another error (which is to be expected cause I don't have a Ledger connected to that machine): ERROR Failed to create private key : Ledger not connected

At least now it is already looking for the Ledger hardware.

[julienrbrt]

Hi!

Binance uses a severely outdated and forked version of the Cosmos SDK (https://github.com/bnb-chain/node/blob/1188e42a166b9f920a24d1b3e6a2142849275102/go.mod#L91). We won't be able to provide any support for that. Best indeed to post an issue in their repo.