Closed RaulBernal closed 6 months ago
Another issue I've noticed is that if I want to manually bump the SDK version to v0.50.3 at the "old v28.0" scaffold I get this error:
Cosmos SDK's version is: v0.50.3
✘ Cannot build app:
error while running command go install github.com/bufbuild/buf/cmd/buf github.com/cosmos/gogoproto/protoc-gen-gocosmos google.golang.org/grpc/cmd/protoc-gen-go-grpc google.golang.org/protobuf/cmd/protoc-gen-go github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2 golang.org/x/tools/cmd/goimports: # github.com/bufbuild/buf/private/pkg/protodescriptor
../../../go/pkg/mod/github.com/bufbuild/buf@v1.27.2/private/pkg/protodescriptor/protodescriptor.go:52:24: cannot use fileDescriptorProto (variable of type *descriptorpb.FileDescriptorProto) as FileDescriptor value in assignment: *descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
have GetEdition() descriptorpb.Edition
want GetEdition() string
../../../go/pkg/mod/github.com/bufbuild/buf@v1.27.2/private/pkg/protodescriptor/protodescriptor.go:71:32: impossible type assertion: fileDescriptor.(*descriptorpb.FileDescriptorProto)
*descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
have GetEdition() descriptorpb.Edition
want GetEdition() string
../../../go/pkg/mod/github.com/bufbuild/buf@v1.27.2/private/pkg/protodescriptor/protodescriptor.go:97:33: cannot use proto.String(edition) (value of type *string) as *descriptorpb.Edition value in assignment
../../../go/pkg/mod/github.com/bufbuild/buf@v1.27.2/private/pkg/protodescriptor/protodescriptor.go:151:36: cannot use fileDescriptorProto (variable of type *descriptorpb.FileDescriptorProto) as FileDescriptor value in argument to ValidateFileDescriptor: *descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
have GetEdition() descriptorpb.Edition
want GetEdition() string
: exit status 1
So I can't test the old scaffold with SDK v0.50.3
To put more context in the issue and discard a SDK problem I tried to downgrade the v28.1.1 scaffold from SDK v0.50.3 to SDK v0.50.2 and also downgrading the IBC-go from v8.1.0 to v8.0.0 being the result the same issue.
v28.0 scaffold is: https://github.com/BitCannaGlobal/bcna/tree/previous_ignite_v28_sdk0.50.2
v28.1.1 scaffold is: https://github.com/BitCannaGlobal/bcna/blob/v4/app/upgrades.go https://github.com/BitCannaGlobal/bcna/tree/v4-no-nft
Here there is a comparation: https://github.com/BitCannaGlobal/bcna/pull/324/files
@tac0turtle I think is not a SDK issue, maybe this issue should be reported at Ignite GitHub, I guess from one version to the last (Ignite v28.0 to v28.1.) there be something breaking. What do you think @julienrbrt ? (I name you because you are actively developing Ignite lastly)
Hi, v28 -> v28.1 had some fixes in IBC module registration. Can you try directly v0.47 -> v0.50.3? That shouldn't be a problem if you add the correct new modules in your `StoreUpgrades.
Concerning your other issue: https://github.com/cosmos/cosmos-sdk/issues/19435#issuecomment-1943614479, the buf dependency was upgraded to github.com/bufbuild/buf v1.28.1
, so you should upgrade that dep too I think.
Hi, v28 -> v28.1 had some fixes in IBC module registration. Can you try directly v0.47 -> v0.50.3? That shouldn't be a problem if you add the correct new modules in your `StoreUpgrades.
OK I haven seen this PR (https://github.com/ignite/cli/pull/3851/files) and I add the StoreUpgrade accordingly:
storeUpgrades := storetypes.StoreUpgrades{ Added: []string{ circuittypes.ModuleName, ibcfeetypes.ModuleName, ibctm.ModuleName, solomachine.ModuleName, // nft.ModuleName, }, }
NFT module was deactivated in app.go_v2 , etc But still:
bcnad start panic: failed to load latest version: version of store feeibc mismatch root store's version; expected 99 got 0; new stores should be added using StoreUpgrades
goroutine 1 [running]: github.com/BitCannaGlobal/bcna/cmd/bcnad/cmd.newApp({0x104583288, 0x14000271a40}, {0x104596c10, 0x140001140b8}, {0x0, 0x0}, {0x1045460c0, 0x14000ac0000}) /Users/raul/SDK/v0.50/bcna/cmd/bcnad/cmd/commands.go:137 +0xa8 github.com/cosmos/cosmos-sdk/server.startApp(0x1400160a980, 0x1045341f8, {0x104534948?, 0x0?, 0x0?}) /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/start.go:642 +0x110 github.com/cosmos/cosmos-sdk/server.start(_, {{0x0, 0x0, 0x0}, {0x10459c770, 0x14000560600}, 0x0, {0x1400108e830, 0xe}, {0x1045ba420, ...}, ...}, ...) /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/start.go:250 +0xd8 github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2.1() /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/start.go:175 +0x58 github.com/cosmos/cosmos-sdk/server.wrapCPUProfile(0x1400160a980, 0x140015177f8) /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/start.go:600 +0x16c github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2(0x14000db4e00?, {0x1060d6ce0?, 0x0?, 0x0?}) /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/start.go:174 +0x194 github.com/spf13/cobra.(Command).execute(0x140013d7200, {0x1060d6ce0, 0x0, 0x0}) /Users/raul/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:983 +0x840 github.com/spf13/cobra.(Command).ExecuteC(0x14001245500) /Users/raul/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115 +0x344 github.com/spf13/cobra.(Command).Execute(...) /Users/raul/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039 github.com/spf13/cobra.(Command).ExecuteContext(...) /Users/raul/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1032 github.com/cosmos/cosmos-sdk/server/cmd.Execute(0x140000aa6e8?, {0x0, 0x0}, {0x140010356f8, 0x11}) /Users/raul/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.3/server/cmd/execute.go:34 +0x154 main.main() /Users/raul/SDK/v0.50/bcna/cmd/bcnad/main.go:15 +0x3c
is there any more to add?
> Concerning your other issue: [#19435 (comment)](https://github.com/cosmos/cosmos-sdk/issues/19435#issuecomment-1943614479), the buf dependency was upgraded to `github.com/bufbuild/buf v1.28.1`, so you should upgrade that dep too I think.
That works! Thanks
I've put some extra log output but as I imagine it happens after the Store issue, so it didn't help, can you point me to any log snippet to know which "new" module is throwing the panic? I've reviewed the code changes but I can't found it
// Print the modules with their respective ver.
for moduleName, version := range fromVM {
app.Logger().Info(fmt.Sprintf("Module: %s, Version: %d", moduleName, version))
}
versionMap, err := app.ModuleManager.RunMigrations(ctx, app.Configurator(), fromVM)
if err != nil {
return nil, err
}
app.Logger().Info(fmt.Sprintf("post migrate version map: %v", versionMap))
// return app.ModuleManager.RunMigrations(ctx, app.Configurator(), fromVM)
return versionMap, err
I think it could be closed, related with Ignite https://github.com/ignite/cli/issues/3971
Is there an existing issue for this?
What happened?
I tested the v0.47 -> v0.50.2 (check this solved issue https://github.com/cosmos/cosmos-sdk/issues/18733) using Ignite v28.0 I was able to upgrade with that code, adding the Store for
circuit
&feeibc
but with the new scaffold with Ignite v0.28.1.1 I can't upgrade:Cosmos SDK Version
v0.50.3
How to reproduce?
schedule a v047 -> v050 upgrade using a proposal. Scaffolding an Ignite v28.1.1 chain and trying to upgrade.
(I was able to do it with a scaffold from v28.0) This is that scaffolded code running the upgrade: