search

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
6.22k stars 3.59k forks source link

feat(baseapp): Remove hybrid handlers #20782

Closed testinginprod closed 2 months ago

testinginprod commented 3 months ago

Description

This PR removes hybrid handlers from baseapp.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The recent update to the `cosmos-sdk` primarily removes hybrid handlers across various modules, simplifying the handling of gRPC queries and message services. Significant refactoring includes the consolidation of handler registration and route mapping processes, transitioning from hybrid handlers to dedicated request handlers. Furthermore, new interfaces and utility functions have been introduced to improve the efficiency and clarity of coin transfers and message handling within the application. ## Changes | File/Group | Change Summary | |------------|----------------| | `CHANGELOG.md` | Removed hybrid handlers from `baseapp`. | | `baseapp/grpcrouter.go`, `baseapp/grpcrouter_test.go` | Refactored gRPC query handling, removed hybrid handlers, and updated router and test cases. | | `baseapp/internal/protoutils/protoutils.go` | Added utility function to retrieve request and response names from method descriptions. | | `baseapp/msg_service_router.go`, `baseapp/msg_service_router_test.go` | Refactored message service router, removed hybrid handlers, updated to register response by request name. | | `runtime/router.go`, `runtime/router_test.go` | Replaced previous hybrid handler methods with new request-based handlers, adjusted message and response handling logic. | | `runtime/v2/go.mod` | Removed several module replacements related to `cosmossdk.io` and `github.com/cosmos/cosmos-sdk`. | | `runtime/v2/stub.go` | Introduced `failingStoreService` type. | | `server/v2/go.mod` | Removed module replacement for `cosmossdk.io/log`. | | `api/cosmos/staking/v1beta1/query.pulsar.go` | Added comments to clarify relationship between `Validators` and `ValidatorInfo` fields in `QueryValidatorsResponse` struct. | | `x/accounts/account_test.go` | Replaced references to bank modules with a mock module for testing. | | `x/accounts/defaults/multisig/utils_test.go` | Changed `ProtoMsg` type from `protoiface.MessageV1` to `gogoproto.Message`. | | `x/accounts/depinject.go` | Added `CoinTransferer` interface to `ModuleInputs` struct and `ProvideModule` function. | | `x/accounts/internal/implementation/encoding.go` | Replaced `protoiface.MessageV1` with `proto.Message` in `ProtoMsgG` interface. | | `x/accounts/keeper.go`, `x/accounts/keeper_test.go` | Added `CoinTransferer` interface, adjusted `Keeper` struct and functions for coin transfers and messaging. | | `x/accounts/proto/cosmos/accounts/testing/mockmodule/mockmodule.proto` | Introduced new file with message definitions for `MsgEcho`, `MsgEchoResponse`, `QueryEchoRequest`, and `QueryEchoResponse`. | | `x/accounts/testing/mockmodule/mock.go` | Added mock implementations for message and query routers. | | `x/accounts/utils_test.go` | Replaced various imports with `appmodule` and `mockmodule`, added `coinTransferer` type and updated `newKeeper` function. | | `x/bank/keeper/keeper.go` | Added `MakeTransferCoinsMessage` function to `BaseKeeper` struct. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
testinginprod commented 2 months ago

will have another pass at this later since fixing it requires rolling back some changes in other modules