crypto: various improvements

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

6.08k stars 3.51k forks source link

crypto: various improvements #2089

Closed ebuchman closed 4 years ago

ebuchman commented 5 years ago

The package has gotten a bit messy and is in need of cleanup. Consider the following.

clarify what function changed in the bcrypt fork
fork the correct go-bip39 into here and remove the current bip39 wrapper
reduce dependencies on tendermint/crypto if/where possible
mintkey.go should be its own pkg with exposed funcs (doesn't need to be covered by semver tho)
add support for bip39 passphrases
add support for generating your own entropy
keybase needs a cleanup (interface seems bloated)

ValarDragon commented 5 years ago

Why are we forking the bip 39 codebase into the sdk? I'm not opposed to forking but wouldn't this be better as a separate repo so we can get upstream updates

ebuchman commented 5 years ago

Why are we forking the bip 39 codebase into the sdk? I'm not opposed to forking but wouldn't this be better as a separate repo so we can get upstream updates

In this case the repo is small enough that we shouldn't be expecting to pull in anything from upstream.

jackzampolin commented 4 years ago

This has been substantially completed. Going to close this issue. Please reopen individual issues for remaining action items