Closed scirner22 closed 1 month ago
Do you have some step to reproduce or some code we could look at?
I'm not totally plugged into the cosmos ecosystem. Is there a reference chain implementation of cosmos-sdk where I can try to verify this across cosmos-sdk versions?
I can provide steps for how to do this on the provenance chain, but it will require more manual steps.
Yes, the reference is simapp in the release/v0.50.x branch: https://github.com/cosmos/cosmos-sdk/tree/release/v0.50.x/simapp
You can install it and configure it with: make install && make init-simapp
I was able to confirm these metrics were lost in simd
as well. Here are the steps to reproduce.
git checkout v0.46.13
make clean && make build
./build/simd testnet init-files --chain-id=testing --output-dir="./testnet" --keyring-backend=test --minimum-gas-prices=0.000001stake --v 1
# set ./testnet/node0/simd/config/config.toml
[instrumentation]
prometheus = true
# set ./testnet/node0/simd/config/app.toml
[telemetry]
enabled = true
prometheus-retention-time = 60
# end file
./build/simd start --log_level=info --home ./testnet/node0/simd
curl http://localhost:26660/metrics | rg iavl
# finds metrics!
git checkout v0.50.7
make clean && make build
rm -rf ./testnet
./build/simd testnet init-files --chain-id=testing --output-dir="./testnet" --keyring-backend=test --minimum-gas-prices=0.000001stake --v 1
# set ./testnet/node0/simd/config/config.toml
[instrumentation]
prometheus = true
# set ./testnet/node0/simd/config/app.toml
[telemetry]
enabled = true
prometheus-retention-time = 60
# end file
./build/simd start --log_level=info --home ./testnet/node0/simd
curl http://localhost:26660/metrics | rg iavl
# missing metrics!
I confirmed these metrics are missing on the main branch as well.
Thank you, I'll investigate!
Found the culprit https://github.com/cosmos/cosmos-sdk/blob/main/baseapp/baseapp.go#L205
Metrics for store needs to be set using SetStoreMetrics
on baseapp.
Did this get fixed? I can't find a PR for it.
There is no fix needed, this needs to be called: https://github.com/cosmos/cosmos-sdk/blob/main/baseapp/options.go#L395-L402
Is there an existing issue for this?
What happened?
After upgrading from v0.46.13 v0.50.7 we seem to have lost some cosmos layer telemetry.
Configuration
Metrics before upgrade
Metrics after upgrade
Cosmos SDK Version
v0.50.7
How to reproduce?
No response