[Bug]: rpc DenomMetadata can't support slash

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:

https://cosmos.network/

Apache License 2.0

6.28k stars 3.64k forks source link

[Bug]: rpc DenomMetadata can't support slash #22542

Closed JoowonYun closed 15 hours ago

JoowonYun commented 1 week ago

Is there an existing issue for this?

[x] I have searched the existing issues

What happened?

We're having trouble querying denoms that contain slashes, like ibc or tokenfactory.

https://github.com/cosmos/cosmos-sdk/pull/16852

Cosmos SDK Version

0.47, 0.50, main

How to reproduce?

curl -X GET "http://localhost:1317/cosmos/bank/v1beta1/denoms_metadata/ibc%2Fabc"

Result

{
  "code": 12,
  "message": "Not Implemented",
  "details": []
}

julienrbrt commented 1 week ago

Hey! This is why the DenomMetadataByQueryString exists, however you PR is a good solution as well. We should do that for all endpoints, but still keep the ByQueryString services.