search

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
6.24k stars 3.61k forks source link

Make `StateKey` `stateKey` #28

Closed ebuchman closed 7 years ago

ebuchman commented 7 years ago

No need to expose this outside the package.

But maybe clients want it because they need to know what to Query for?

rigelrozanski commented 7 years ago

StateKey is not a required interface function of plugin. Within paytovote StateKey isn't even used, individual keys for each issue are generated using IssueKey, which IS in fact called by the paytovote CLI extension commands for the paytovote-query command... so It does need to be exposed in this example. Makes sense generally to allow for other plugins to query right out of the state? Even if StateKey isn't used in the example plugins within basecoin I imagine most complex plugins will want access for CLI extendibility

ebuchman commented 7 years ago

Frey had included this as a TODO in his edits to the docs. I pulled it out into an issue, but I don't even think it is one because clients might need the state key to provide custom query commands

adrianbrink commented 7 years ago

@rigelrozanski @ebuchman Can this be closed, since it seems we want to expose it?

ethanfrey commented 7 years ago

Sure. Closing...