REST Account/Balance query duplicated logic

[MarinX]

Summary

In x/auth/client/rest/query.go we have 2 REST methods which are the same except the response.

Problem Definition

The first REST method /auth/accounts/{address} has a handler QueryAccountRequestHandlerFn, which returns the account.

The second REST method /bank/balances/{address} has a handler QueryBalancesRequestHandlerFn, which returns account coins.

Both methods do the same validation, querying and error checking. Only difference is the response (account or account coins)

Proposal

• Rewrite duplicated Query*RequestHandlerFn to be a single handler function (code cleanup)
• Change to be more RESTfull (api breaking change) from /auth/accounts/{address} /bank/balances/{address} to /auth/accounts/{address} /auth/accounts/{address}/balances

  ---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[MarinX]

Related conversation #4065

[alexanderbez]

Thanks @MarinX. I'm thinking do we even need two endpoints? Why not just have an account query endpoint? That'll have the balance anyway.

[fedekunze]

++ agree with @alexanderbez here

[alexanderbez]

Closing. Has been already addressed by @fedekunze :)