search

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
6.25k stars 3.62k forks source link

Develop Bug #554

Closed rigelrozanski closed 6 years ago

rigelrozanski commented 6 years ago

CLI develop is broken - I think by the go-wire revision, but glide tendermint version is missing from older commits so I can’t test hypothesis :disappointed: - we need better CLI auto-testing in here asap to avoid situations like this… basecli breaks after this step of attempting to query the genesis account 

make get_vendor_deps && make build
rm -rf ~/.basecoind ~/.basecli

Terminal 1:
./build/basecoind init
# copy seed phrase into clipboard
./build/basecoind start

Terminal 2:
./build/basecli keys add demo --recover
# use password “1234567890”, hardcoded in sendtx right now
# enter the seedphrase above, and 
# store the address returned as ADDR
./build/basecli account $ADDR --node=localhost:46657

I traced back the error (even though --trace doesn't work) to coming from the unmarshal step here: https://github.com/cosmos/cosmos-sdk/blob/develop/examples/basecoin/types/account.go#L29

ebuchman commented 6 years ago

we need better CLI auto-testing in here asap to avoid situations like this

While I agree we need better CLI testing, this is actually a failure of the units tests. This kind of basic functionality should absolutely have a test that would have caught this. Note there are no tests in the examples/basecoin/types package!

ebuchman commented 6 years ago

Let's not change anything in the SDK until we write more tests! https://github.com/cosmos/cosmos-sdk/issues/555 and https://github.com/cosmos/cosmos-sdk/issues/556