search

cosmos / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Apache License 2.0
6.24k stars 3.61k forks source link

Coins IsValid() Ordering #8

Closed rigelrozanski closed 7 years ago

rigelrozanski commented 7 years ago

It appears as though the IsValid() method is only checking if each coin is sorted against the first coin denom, not the previous denom in order? https://github.com/tendermint/basecoin/blob/master/types/coin.go#L30-L34

ethanfrey commented 7 years ago

You are very right. Fixed in develop, commit 2f7875d