Closed alexanderbez closed 5 years ago
I believe most of the routing logic is done. Just need to update (re-implement) the ante handler unit tests.
I'd like to review this but it's a bit lower priority than GoS.
If you can wait a day or two @alexanderbez I promise to get to it :wink:.
No rush @cwgoes -- take your time.
@cwgoes I believe I addressed most of your comments 👍
Redesign the way Ethereum transactions are handled by treating them as first class citizen types along with any potential future SDK messages types by using the Amino encoding protocol. Web3 compatibility is still maintained as Ethereum transactions will still be RLP encoded over the wire but to Tendermint, they'll be re-encoded via Amino.
Changes:
Transaction
to be asdk.Msg
Transaction
changesNote: The ante handler is practically identical to the Cosmos SDK ante handler atm.
closes: #492
Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
[x] Wrote tests
[ ] Updated relevant documentation (
docs/
)[ ] Added entries in
PENDING.md
with issue #[x] rereviewed
Files changed
in the github PR explorerFor Admin Use: