cosmos / gosec

Apache License 2.0
19 stars 6 forks source link

all: fix tests by migrating to github.com/onsi/ginkgo/v2 #47

Closed odeke-em closed 2 years ago

odeke-em commented 2 years ago

Fixes a stale dependency by migrating to the recommended v2 version, and that was purposefully failing tests such as in https://github.com/cosmos/gosec/actions/runs/3116664571/jobs/5054700976#step:5:647

While here, also fixed a flake with comparisons of sorts that weren't in order.

codecov-commenter commented 2 years ago

Codecov Report

Base: 70.86% // Head: 71.77% // Increases project coverage by +0.90% :tada:

Coverage data is based on head (aa9df55) compared to base (c75406a). Patch coverage: 85.36% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #47 +/- ## ========================================== + Coverage 70.86% 71.77% +0.90% ========================================== Files 9 9 Lines 587 627 +40 ========================================== + Hits 416 450 +34 - Misses 146 149 +3 - Partials 25 28 +3 ``` | [Impacted Files](https://codecov.io/gh/cosmos/gosec/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos) | Coverage Δ | | |---|---|---| | [call\_list.go](https://codecov.io/gh/cosmos/gosec/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos#diff-Y2FsbF9saXN0Lmdv) | `90.90% <ø> (ø)` | | | [config.go](https://codecov.io/gh/cosmos/gosec/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos#diff-Y29uZmlnLmdv) | `82.92% <ø> (ø)` | | | [helpers.go](https://codecov.io/gh/cosmos/gosec/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos#diff-aGVscGVycy5nbw==) | `45.83% <ø> (ø)` | | | [analyzer.go](https://codecov.io/gh/cosmos/gosec/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos#diff-YW5hbHl6ZXIuZ28=) | `88.23% <85.36%> (-0.79%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cosmos)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.