cosmos / iavl

Merkleized IAVL+ Tree implementation in Go
Apache License 2.0
417 stars 263 forks source link

fix: memory leak in `Import` #773

Closed yihuang closed 1 year ago

yihuang commented 1 year ago

Closes: #772

don't need to reference the children, which recursively retain the whole subtree in memory.

tac0turtle commented 1 year ago

removing what comments? i didnt touch anything other than merge. If i deleted a comment it would say a comments were deleted, not sure what youre talking about

joshlopes commented 1 year ago

@tac0turtle the comments are back, probably a hiccup within GH API, basically I left the comments above and you merged the PR - I saw the event merged and the comments were no were so I assumed you had deleted them to merge/don't stale.

Apologies! 🙇