cosmos / iavl

Merkleized IAVL+ Tree implementation in Go
Apache License 2.0
417 stars 263 forks source link

fix: rootKey empty check by len equals 0 #801

Closed mmsqe closed 1 year ago

mmsqe commented 1 year ago

this change should not have been included in e46665c71763e5b5c77ce7215e3b7f80167a3951

mmsqe commented 1 year ago

@tac0turtle Is it possible that we backport this to v0.20.x?

tac0turtle commented 1 year ago

@tac0turtle Is it possible that we backport this to v0.20.x?

i dont see this being part of v0.20. I might be looking the wrong place, are you able to see it?

mmsqe commented 1 year ago

@tac0turtle Is it possible that we backport this to v0.20.x?

i dont see this being part of v0.20. I might be looking the wrong place, are you able to see it?

Yes, https://github.com/cosmos/iavl/blob/release/v0.20.x/iterator.go#L272

julienrbrt commented 1 year ago

If this gets backported in v0.20, we should backport it in v1.0.0 and v0.21 as well.

julienrbrt commented 1 year ago

@mergifyio backport release/v1.x.x

mergify[bot] commented 1 year ago

backport release/v1.x.x

✅ Backports have been created

* [#809 fix: rootKey empty check by len equals 0 (backport #801)](https://github.com/cosmos/iavl/pull/809) has been created for branch `release/v1.x.x` but encountered conflicts
tac0turtle commented 1 year ago

@mergifyio backport release v0.20.x

mergify[bot] commented 1 year ago

backport release v0.20.x

❌ No backport have been created

* Backport to branch `release` failed GitHub error: ```Branch not found``` * Backport to branch `v0.20.x` failed GitHub error: ```Branch not found```
tac0turtle commented 1 year ago

@mergifyio backport release/v0.20.x

mergify[bot] commented 1 year ago

backport release/v0.20.x

✅ Backports have been created

* [#810 fix: rootKey empty check by len equals 0 (backport #801)](https://github.com/cosmos/iavl/pull/810) has been created for branch `release/v0.20.x` but encountered conflicts
julienrbrt commented 1 year ago

@Mergifyio backport release/v0.21.x

mergify[bot] commented 1 year ago

backport release/v0.21.x

✅ Backports have been created

* [#811 fix: rootKey empty check by len equals 0 (backport #801)](https://github.com/cosmos/iavl/pull/811) has been created for branch `release/v0.21.x` but encountered conflicts