Closed catShaark closed 1 year ago
That's because I discussed with marko and we decide to hard code the value to be the best option based on benchmark result run on osmosis node
+1 on @cool-develope comment.
Given that newNodeDB
takes Options
we could add an option in here: https://github.com/notional-labs/iavl/blob/a945f5f903800a214d30e55f87ca96cc6bc78051/options.go#L71-L89 and use 100000
in the DefaultOptions. If going this way, we should make them variadic so you don't end up overwriting that value to 0 by defining new options.
@julienrbrt you fine with merging this and then i can make the changes.
@julienrbrt you fine with merging this and then i can make the changes.
Works! We need changelogs as well to reflect some API breaks from here in the follow-up
@mergifyio backport release/1.x.x
backport release/1.x.x
@Mergifyio backport release/v1.x.x
@mergifyio backport release/v1.x.x
backport release/v1.x.x
This PR replace the use of normal dbm.Batch with BatchWithFlusher in iavl tree It also hard code the value of flushthreshold to 100KB