Closed tac0turtle closed 1 month ago
[!WARNING]
Review Failed
The head commit changed during the review from af8478dbc4bf3636330138e3ac32c246f3a8b99c to 65dd14a41f201ce4c08dac7a4b9fabbb678df61f.
The changes involve updating the import path for the logging module across multiple files from "cosmossdk.io/log"
to "cosmossdk.io/core/log"
. Additionally, in migrate_test.go
, the logger initialization was updated from log.NewTestLogger(t)
to log.NewNopLogger()
. These changes likely reflect a reorganization of the logging package within the cosmossdk.io
library.
Files | Change Summary |
---|---|
basic_test.go , tree_test.go |
Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log" . |
benchmarks/bench_test.go , tree_random_test.go |
Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log" . |
benchmarks/cosmos-exim/main.go , diff_test.go , immutable_tree.go , import_test.go , iterator_test.go , migrate_test.go , mutable_tree.go , mutable_tree_test.go , nodedb.go , nodedb_test.go , proof_iavl_test.go , proof_ics23_test.go , testutils_test.go |
Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log" . |
migrate_test.go |
Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log" and changed log.NewTestLogger(t) to log.NewNopLogger() . |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This pr uses cosmossdk.io/core/log instead of cosmossdk.io/log to avoid the import of zero log and implementation specific items.
This is a proposal for dep cleanup
Summary by CodeRabbit
log.NewTestLogger(t)
withlog.NewNopLogger()
inmigrate_test.go
for logging consistency.