cosmos / ibc-apps

IBC applications and middleware for Cosmos SDK chains.
Apache License 2.0
82 stars 62 forks source link

chore: remove `IBCMiddleware.refundTimeout` as it is no longer used #189

Closed ysv closed 3 months ago

ysv commented 4 months ago

I was trying to understand meaning of refundTimeout inside IBCMiddleware but didn't find any usage of this attribute except initialization (3 times) and unit test (2 times) - see screenshot.

I'm still wondering what is the reason behind and if it should be present at all.

Screenshot 2024-05-01 at 17 47 15
Reecepbcups commented 3 months ago

cc @jtieri since you did a bit of refund work iirc due to Mandrake

agouin commented 3 months ago

This parameter is no longer used after the introduction of atomic acks. It can be safely ignored (set to arbitrary value) and should be removed in a future release