search

cosmos / ibc-apps

IBC applications and middleware for Cosmos SDK chains.
Apache License 2.0
82 stars 62 forks source link

feat: migrate ibc rate limiting #191

Closed johnletey closed 3 months ago

johnletey commented 3 months ago

This PR migrates the IBC Rate Limiting module built by Stride Labs.

It migrates from @Reecepbcups' feat/sdk-v50, with a small addition from Noble's team to support app wiring (commit).

Closes #188.

Reecepbcups commented 3 months ago

strides proto naming should be kept as they are the originator of the module. Similar to osmosis tokenfactory. changing proto namespace breaks all upstream tooling and apps and bots. Especially with rust libs

johnletey commented 3 months ago

Reverted the query changes @Reecepbcups!

Reecepbcups commented 3 months ago

Thanks! I will review this once I talk with the stride team and also get them setup to coordinate. Ill review the diff from my v50 branch & this. I will be a little slow here as I just got back from vacation so might be more so a next week thing FYI

Reecepbcups commented 3 months ago

Reviewed and looks good! A few minor things I found in my diff review: https://github.com/Reecepbcups/ratelimitdif/pull/1

but I will handle in another PR. Thank you so so much for this addition! Really appreciate it a ton :heart: