search

cosmos / ibc-apps

IBC applications and middleware for Cosmos SDK chains.
Apache License 2.0
82 stars 62 forks source link

deps(v7)!: bump IBC-Go v7.6.0 #199

Closed Reecepbcups closed 1 month ago

Reecepbcups commented 2 months ago

Will tag as packet-forward-middleware v7.2.0

Reecepbcups commented 2 months ago

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

jtieri commented 2 months ago

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

so weird it looks like it is still returning some errors. i didn't deep dive this but it almost looks like the things it is complaining about aren't even issues in this repo though but rather one of the dependencies?

Reecepbcups commented 2 months ago

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

jtieri commented 2 months ago

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

what should we do with this, just approve and merge?

Reecepbcups commented 2 months ago

@jtieri yea I think so. Nothing blocking on our end, passes locally for me so linting is not an issue

Reecepbcups commented 1 month ago

closing, do in the new v7 backport PR