cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
553 stars 597 forks source link

Turn `GetConsensusState` to `HasConsensusState` #4010

Closed crodriguezvega closed 1 year ago

crodriguezvega commented 1 year ago

Surfaced from Interchain IBC team's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

Pre-requisite:

Once issue #3957 is addressed, the remaining usages of GetConsensusState do not involve doing anything with the returned consensus state (i.e. it's only used to determine if the consensus state exists in store or not), so the function could just be turned into HasConsensusState to reduce gas consumption. It might also be possible to make the function unexported.

crodriguezvega commented 1 year ago

Closed by #4147