chatton
commented
1 year ago Adding some sample code I was experimenting with as a reference
func TestLedgerTestSuite(t *testing.T) {
testifysuite.Run(t, new(LedgerTestSuite))
}
type LedgerTestSuite struct {
testsuite.E2ETestSuite
}
// CreateLedgerKey creates a key in the keyring backend test for the given node
func CreateLedgerKey(ctx context.Context, name string, chain *cosmos.CosmosChain) error {
_, _, err := chain.Nodes()[0].ExecBin(ctx,
"keys", "add", name,
"--coin-type", chain.Config().CoinType,
"--keyring-backend", keyring.BackendTest,
"--ledger",
"--account", "1",
)
return err
}
func GetAndFundLedgerWallet(
ctx context.Context,
amount int64,
chain ibc.Chain,
) (ibc.Wallet, error) {
chainCfg := chain.Config()
keyName := "ledgerKey"
if err := CreateLedgerKey(ctx, keyName, chain.(*cosmos.CosmosChain)); err != nil {
return nil, fmt.Errorf("failed to create key %q on chain %s: %w", keyName, chainCfg.Name, err)
}
addrBytes, err := chain.GetAddress(ctx, keyName)
if err != nil {
return nil, fmt.Errorf("failed to get account address for key %q on chain %s: %w", keyName, chain.Config().Name, err)
}
wallet := cosmos.NewWallet(keyName, addrBytes, "", chain.Config())
err = chain.SendFunds(ctx, interchaintest.FaucetAccountKeyName, ibc.WalletAmount{
Address: wallet.FormattedAddress(),
Amount: sdkmath.NewInt(amount),
Denom: chainCfg.Denom,
})
if err != nil {
return nil, fmt.Errorf("failed to get funds from faucet: %w", err)
}
return wallet, nil
}
func (s *LedgerTestSuite) TestLedger() {
t := s.T()
ctx := context.TODO()
relayer, channelA := s.SetupChainsRelayerAndChannel(ctx, s.TransferChannelOptions())
chainA, chainB := s.GetChains()
chainADenom := chainA.Config().Denom
ledgerWallet, err := GetAndFundLedgerWallet(ctx, testvalues.StartingTokenAmount, chainA)
s.Require().NoError(err)
ledgerAddress := ledgerWallet.FormattedAddress()
s.T().Logf("ledgerAddress: %s", ledgerAddress)
}
damiannolan
Summary
I propose we add a test (using interchain test) to test ledger support.
This would not be run on PRs, but would be something that can be manually triggered. I experimented briefly with the idea, and there are a few things that would be some changes needed to interchaintest to support this behaviour.
Firstly, there is an open issue that prevents this from working at all on a Mac, the test would have to be run from a linux host machine (or at least using a linux machine with the
DOCKER_HOSTenvironment variable )I was able to add a ledger key successfully with the following command
Note: the following also works
The general idea for the test would be to configurable address which is specified in a config file/env, fund that address in setup. Perform a regular transfer test and have the tx signed manually using the ledger as the test runs.
All of this should be possible with just a few modifications to interchain test.
Changes in interchain test that would be required for this to be possible:
For Admin Use