Call `Pin` during app inisitalization

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

548 stars 586 forks source link

Call `Pin` during app inisitalization #5073

Closed DimitrisJim closed 10 months ago

DimitrisJim commented 11 months ago

Feedback from Simon's peer review:

Pin needs to be called on every start. See https://github.com/CosmWasm/wasmd/blob/v0.44.0/app/app.go#L808 for the wasmd equivalent

Can be done after feature branch is merged.

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

vuong177 commented 11 months ago

@DimitrisJim could I work on this issue ?

DimitrisJim commented 11 months ago

You most certainly can @vuong177, thanks!

Do note that it should be worked on after the feature branch for 08-wasm is merged which should be sometime next week. I'll ping you and let you know!

damiannolan commented 11 months ago

Hi @vuong177, are you still planning to PR this issue? I believe the feature branch has been merged

vuong177 commented 11 months ago

@damiannolan yes I'm working on this. I'll make a PR soon !