search

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
548 stars 586 forks source link

Replace occurences of codeHash, code_hash with checkSum #5074

Closed DimitrisJim closed 11 months ago

DimitrisJim commented 11 months ago

Feedback from Simon's peer review:

Consistently rename code_hash -> checksum. Those are two terms for the same thing, which is confusing. cosmwasm-vm/wasmvm uses “checksum” everywhere.

We might want to use a different name for the hex encoded checksums returned by the QueryCodeHashesRequest and the one supplied to QueryCodeRequest. checkSumHex is an unimaginative first stab at it.

Can be done after feature branch is merged.

For Admin Use

DimitrisJim commented 11 months ago

note: will probably require updates to documentation

colin-axner commented 11 months ago

This can be closed?

DimitrisJim commented 11 months ago

This can be closed?

keeping open for doc changes, wanted to push through main changes and keep the docs amendments in a follow up