Check that code hash was not modified in migrate call

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

548 stars 586 forks source link

Check that code hash was not modified in migrate call #5104

Closed DimitrisJim closed 11 months ago

DimitrisJim commented 11 months ago

After calling migrate we should check that the code hash stored in the client state was not modified. Though not a crucial issue this helps ensure the contract isn't doing any conspicuous writes and unifies the error checking for all entry points that might modify state.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

DimitrisJim commented 11 months ago

closing this, the benefit isn't quite there since we'll unequivocally re-write the checksum after finishing with the call. Changes to allow the check outweigh benefit in unifying error checking.