Update to typed IBC events

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

531 stars 573 forks source link

Update to typed IBC events #54

Closed colin-axner closed 1 week ago

colin-axner commented 4 years ago

Summary

see comment.

This would ideally happen in all of the ibc module as well as the ibc-transfer module. Documentation would need to be added to the relayer guide to give example interaction with consuming the events

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

crodriguezvega commented 3 weeks ago

Looking at the Akash codebase (as mentioned in the comment linked in the description), looks like for each event we would have a type and the event would have an attribute where all the fields of the type are JSON-encoded (see example here). Do we still consider this as something we would do in the future?

colin-axner commented 1 week ago

Personally I think we should close this issue. There hasn't been any activity on this issue nor requests to complete it, which makes me believe the events we have now work just fine

crodriguezvega commented 1 week ago

Personally I think we should close this issue. There hasn't been any activity on this issue nor requests to complete it, which makes me believe the events we have now work just fine

Agree!