Build 08-wasm with libwasmvm linking disabled

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

548 stars 586 forks source link

Build 08-wasm with libwasmvm linking disabled #5903

Closed damiannolan closed 6 months ago

damiannolan commented 7 months ago

Summary

Similarly to x/wasm add a NewKeeper constructor func for 08-wasm which panics when used. This should be guarded by the: //go:build !cgo build flags.

Additionally, we can add //go:build csgo for the keeper file which already exists.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

damiannolan commented 7 months ago

This should allow users to consume types without needing the entire CGO stack for wasmvm.

damiannolan commented 7 months ago

We have chosen to use a separate build tag ibcwasm_novm instead of completely disabling cgo. It's possible that a binary may need cgo dependencies as well as wanting 08-wasm types only available to them

damiannolan commented 7 months ago

Renamed the issue to reflect the desired behaviour