cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
543 stars 577 forks source link

migrate external apis to use context.Context #5917

Open tac0turtle opened 6 months ago

tac0turtle commented 6 months ago

Summary

Migrate all external apis to use context.Context instead of sdk.Context. In most cases you can unwrap the context where its needed. Note that in next release this will be a requirement for users to use server/v2. Its very tedious but a changes that needs to happen.

on top of the next release for ibc it will be required that all modules take environment instead of unwrapping context in order for users to use server/v2 otherwise bugs will arise in ibc when users begin building more complex applications

Problem Definition

in the current releases this is an annoyance when updating users since the sdk uses all context.Context but ibc still uses sdk.Context.

Proposal

As part of the next release of IBC with the sdk it should be required to migrate/break apis to allow people to use server/v2.

SDK team can assist on this


For Admin Use

damiannolan commented 2 weeks ago

When the code PRs are all merged we should: