Add pre-commit hook to run `make proto-all`

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

548 stars 580 forks source link

Add pre-commit hook to run `make proto-all` #6668

Closed bznein closed 2 months ago

bznein commented 3 months ago

We currently have no way to ensure that make proto-all has been run when changing .proto files (except for manually reviewing the generated code). We could add a pre-commit hook that ensures this.

PanGan21 commented 3 months ago

Hi! I am interested to work on this issue if noone else is working on it 🙂

crodriguezvega commented 3 months ago

I don't think anyone is working on it, so for for it @PanGan21. Thank you!

PanGan21 commented 3 months ago

Hey @crodriguezvega it would be helpful to get some feedback on #6678 whenever there is capacity

bznein commented 2 months ago

As discussed in the PR comment, we unfortunately decided to abandon this issue, thanks for the help!