Closed AdityaSripal closed 1 month ago
Note: I also changed the timeout handling to seconds in this PR
I noticed that the packet and msg_server files are using a mix of errors from the v2/types package and the original types package.
Think we need to make a consistent decision and go with that. Think it should all just use v2/errors so we're not importing from channel/v1 at all. Will make an issue to address in separate PR
Failed conditions
63.8% Coverage on New Code (required ≥ 80%)
I believe the test cov is failing because I removed packet-server/relay_test.go without removing relay.go. Think the deletion of packetserver should happen in a new PR hence the issue #7477
Description
closes: #7443
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.