cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
554 stars 593 forks source link

channel/v2: Add Keeper Tests #7456

Closed AdityaSripal closed 1 month ago

AdityaSripal commented 1 month ago

Description

closes: #7443


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

AdityaSripal commented 1 month ago

Note: I also changed the timeout handling to seconds in this PR

AdityaSripal commented 1 month ago

I noticed that the packet and msg_server files are using a mix of errors from the v2/types package and the original types package.

Think we need to make a consistent decision and go with that. Think it should all just use v2/errors so we're not importing from channel/v1 at all. Will make an issue to address in separate PR

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
63.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

AdityaSripal commented 1 month ago

I believe the test cov is failing because I removed packet-server/relay_test.go without removing relay.go. Think the deletion of packetserver should happen in a new PR hence the issue #7477