chore: rename channel to channel end in v2 - Githubissues

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

554 stars 593 forks source link

chore: rename channel to channel end in v2 #7515

Closed damiannolan closed 1 month ago

damiannolan commented 1 month ago

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

damiannolan commented 1 month ago

On second thought maybe we should just leave this called Channel as it was in v1.

channelEnd was just a variable name used in some handlers when dealing with handshakes etc iirc.

I'll close and if we want to go back to this we can resurect it