cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
554 stars 593 forks source link

support client identifiers as channels in ics20 denom hops #7551

Closed gjermundgaraba closed 1 week ago

gjermundgaraba commented 2 weeks ago

Description

Due to the possibility of using client identifiers as the channel id in IBC Eureka (this is what we do in the solidity implementation), the ICS20 parsing of denoms fails when receiving an ics20-1 packet with something like transfer/07-tendermint-0/uatom.

This change allows for client identifiers as well as channel identifiers in the parsing logic. As it stands in this PR, this change would also affect IBC Classic as this code is currently reused.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud