Due to the possibility of using client identifiers as the channel id in IBC Eureka (this is what we do in the solidity implementation), the ICS20 parsing of denoms fails when receiving an ics20-1 packet with something like transfer/07-tendermint-0/uatom.
This change allows for client identifiers as well as channel identifiers in the parsing logic. As it stands in this PR, this change would also affect IBC Classic as this code is currently reused.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.
Description
Due to the possibility of using client identifiers as the channel id in IBC Eureka (this is what we do in the solidity implementation), the ICS20 parsing of denoms fails when receiving an ics20-1 packet with something like
transfer/07-tendermint-0/uatom
.This change allows for client identifiers as well as channel identifiers in the parsing logic. As it stands in this PR, this change would also affect IBC Classic as this code is currently reused.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.