feat: adding runtime Environment to icacontroller - Githubissues

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.

https://ibc.cosmos.network/

MIT License

554 stars 593 forks source link

feat: adding runtime Environment to icacontroller #7587

Open damiannolan opened 4 days ago

damiannolan commented 4 days ago

Description

This PR is work in progress.

Initially adding runtime Environment to ica to address events propagation issue with unwrapping context. All tests seem to be now passing on this branch, except for some build err in e2e unit tests which we will address separately.

Will create an issue for this work later

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

damiannolan commented 10 hours ago

Maybe we need to update linter versions or something in CI. Not sure what the arm64 build failure is too. Probably need to look into it