search

cosmos / ibc-go

Inter-Blockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
548 stars 579 forks source link

Remove docker builds from makefile #8

Closed colin-axner closed 1 year ago

colin-axner commented 3 years ago

The makefile needs to be update so the building of simd command work

hiromaily commented 3 years ago

I have a same issue when building by make build-simd-all commands.

$ make build-simd-all                                                                                                                                                                          (git)-[main]
/usr/local/bin/docker rm latest-build || true
Error: No such container: latest-build
/usr/local/bin/docker run --volume=/Users/hiroki.yasui/go/src/github.com/cosmos/ibc-go:/sources:ro \
        --env TARGET_PLATFORMS='linux/amd64 darwin/amd64 linux/arm64 windows/amd64' \
        --env APP=simd \
        --env VERSION=0afa15a \
        --env COMMIT=0afa15af41997cfb4c5dd5f98de8043961e26195 \
        --env LEDGER_ENABLED=true \
        --name latest-build cosmossdk/rbuilder:latest
Unable to find image 'cosmossdk/rbuilder:latest' locally
latest: Pulling from cosmossdk/rbuilder
57df1a1f1ad8: Pull complete
71e126169501: Pull complete
1af28a55c3f3: Pull complete
03f1c9932170: Pull complete
f4773b341423: Pull complete
fb320882041b: Pull complete
24b0ad6f9416: Pull complete
948c129097c1: Pull complete
e826624c5cbf: Pull complete
59e51b1435b2: Pull complete
08be3a7c19b3: Pull complete
b9267aceca28: Pull complete
Digest: sha256:0870f37eb666e4c4be9fd22892a32c70247b177008fff06f27b2fb708fe95c34
Status: Downloaded newer image for cosmossdk/rbuilder:latest
/bin/bash: /sources/.build.sh: No such file or directory
make: *** [build-simd-all] Error 127

It would be caused by incompatible docker image from source code.

This docker image is not maintained for a while. https://hub.docker.com/r/cosmossdk/rbuilder/tags?page=1&ordering=last_updated

colin-axner commented 3 years ago

Looks like we are missing the .build.sh file https://github.com/cosmos/cosmos-sdk/blob/master/.build.sh

Is building simd in docker useful to you? make build and make install work. I'm wondering if we should just remove all the docker stuff for now

hiromaily commented 3 years ago

@colin-axner As you said, make build is enough. But broken make task would confuse newbies like me.