search

cosmos / ibc-proto-rs

Rust Protobuf definitions and gRPC clients for interacting with Cosmos SDK, IBC and Interchain Security
Apache License 2.0
45 stars 26 forks source link

Update to Prost 0.12.0 #145

Closed hdevalence closed 11 months ago

hdevalence commented 11 months ago

Hi, we'd like to migrate to Prost 0.12.0, but we need to have compatibility across all of our deps. Would it be possible to get an ibc-proto-rs release using prost 0.12.0?

tony-iqlusion commented 11 months ago

Notably this release includes a Name trait which can be used to compute the type_url for Any types, when impl'd for a particular Message type: https://docs.rs/prost/latest/prost/trait.Name.html#method.type_url

Unfortunately there isn't yet prost-build automation for generating impls of that trait, but hopefully it's coming soon.

hdevalence commented 11 months ago

Yes, that's the big reason we're interested in it -- we had our own version of that trait, reorganized all our protos, and are hoping to avoid having to go and update all the type urls manually: https://github.com/penumbra-zone/penumbra/pull/3077#issuecomment-1730866734

romac commented 11 months ago

I'll get to this right after I publish v0.36.0.