search

cosmos / ibc-proto-rs

Rust Protobuf definitions and gRPC clients for interacting with Cosmos SDK, IBC and Interchain Security
Apache License 2.0
42 stars 25 forks source link

rebase `romac/channel-upgrade-only` with main #177

Closed crodriguezvega closed 6 months ago

crodriguezvega commented 6 months ago

@romac @Farhad-Shabani Sorry, I just realised that I should have probably targeted the other PR to romac/channel-upgrade-only branch, since that is the one used in the hermes branch that is adding support for channel upgradability. This PR should get the latest of main into the branch.

Farhad-Shabani commented 6 months ago

@romac @Farhad-Shabani Sorry, I just realised that I should have probably targeted the other PR to romac/channel-upgrade-only branch, since that is the one used in the hermes branch that is adding support for hermes. This PR should get the latest of main into the branch.

No worries at all @crodriguezvega! I was under the impression that revision of ibc-go was tagged, and since we need a new release, I was in the process of cutting a new one to incorporate our latest updates. Thanks for the heads-up 🙂 If that's the case, maybe we should stick with a tagged version of IBC_GO_COMMIT on the main and reconsider (https://github.com/cosmos/ibc-proto-rs/pull/172). What do you think @romac ?

romac commented 6 months ago

Agreed, if the commit in #172 does not correspond to a tagged release of ibc-go, then let's revert #172.