search

cosmos / ibc-proto-rs

Rust Protobuf definitions and gRPC clients for interacting with Cosmos SDK, IBC and Interchain Security
Apache License 2.0
42 stars 25 forks source link

Extend `ibc::mock` types with more data fields #188

Closed rnbguy closed 5 months ago

rnbguy commented 6 months ago

Closes #186

rnbguy commented 6 months ago

I am a bit confused about how to run the build step. When I run ./scripts/sync-protobuf.sh, I see changes at places other than src/prost/ibc.mock*.rs and src/prost/proto_descriptor.bin :sweat_smile:

cc @romac @Farhad-Shabani

Farhad-Shabani commented 6 months ago

I am a bit confused about how to run the build step. When I run ./scripts/sync-protobuf.sh, I see changes at places other than src/prost/ibc.mock*.rs and src/prost/proto_descriptor.bin 😅

cc @romac @Farhad-Shabani

Make sure you are using the latest version of proto compiler (libprotoc v0.25)

rnbguy commented 6 months ago

I am using v0.25.1 - do I have to get the latest v0.25.2?

Farhad-Shabani commented 5 months ago

I am using v0.25.1 - do I have to get the latest v0.25.2?

Per our discussion, the issue of non-relevant changes should be resolved by placing "google/*" imports under the "ibc/*". Perhaps we later should consider using buf.yaml for linting.

rnbguy commented 5 months ago

@Farhad-Shabani as per our discussion, I simplified the definitions :slightly_smiling_face:

rnbguy commented 5 months ago

@Farhad-Shabani thanks for the nits :sweat_smile: totally missed them ! I don't have access to this repo - please, go ahead with the merge. :handshake: