cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 74 forks source link

fix: bump MSRV to 1.71.1 #1119

Closed rnbguy closed 3 months ago

rnbguy commented 4 months ago

Closes: #1118 Closes: #1101 Closes: #1120

Description

PR author checklist:

Reviewer checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 64.70588% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 66.54%. Comparing base (e1f19af) to head (6161f2c).

Files Patch % Lines
ibc-apps/ics20-transfer/src/module.rs 9.09% 20 Missing :warning:
ibc-apps/ics721-nft-transfer/src/module.rs 9.52% 19 Missing :warning:
ibc-core/ics02-client/types/src/error.rs 0.00% 6 Missing :warning:
...ics24-host/cosmos/src/upgrade_proposal/proposal.rs 0.00% 4 Missing :warning:
ibc-clients/ics07-tendermint/types/src/error.rs 0.00% 3 Missing :warning:
ibc-core/ics03-connection/types/src/error.rs 0.00% 3 Missing :warning:
ibc-derive/src/client_state.rs 70.00% 3 Missing :warning:
ibc-primitives/src/types/timestamp.rs 88.88% 3 Missing :warning:
...stkit/src/testapp/ibc/clients/mock/client_state.rs 0.00% 3 Missing :warning:
...ics07-tendermint/src/client_state/update_client.rs 88.88% 2 Missing :warning:
... and 11 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1119 +/- ## ========================================== + Coverage 66.51% 66.54% +0.02% ========================================== Files 209 209 Lines 20725 20617 -108 ========================================== - Hits 13785 13719 -66 + Misses 6940 6898 -42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnbguy commented 3 months ago

btw, I want to fix one more lint but the changes are too big. You can try it by running

cargo clippy --fix -- -W clippy::use_self