cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 74 forks source link

feat: implement client recovery feature #1127

Closed seanchen1991 closed 3 months ago

seanchen1991 commented 3 months ago

Closes: #1110 Closes: #1111 Closes: #1112

Description


PR author checklist:

Reviewer checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 52.67176% with 124 lines in your changes are missing coverage. Please review.

Project coverage is 63.98%. Comparing base (b0ea4ea) to head (fce139c).

Files Patch % Lines
...nts/ics07-tendermint/src/client_state/execution.rs 0.00% 55 Missing :warning:
...ts/ics07-tendermint/src/client_state/validation.rs 0.00% 39 Missing :warning:
...core/ics02-client/types/src/msgs/recover_client.rs 0.00% 20 Missing :warning:
ibc-core/ics25-handler/src/entrypoint.rs 0.00% 8 Missing :warning:
ibc-core/ics02-client/types/src/status.rs 85.71% 1 Missing :warning:
.../ics24-host/cosmos/src/upgrade_proposal/handler.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1127 +/- ## ========================================== - Coverage 64.10% 63.98% -0.12% ========================================== Files 217 219 +2 Lines 21068 21313 +245 ========================================== + Hits 13505 13638 +133 - Misses 7563 7675 +112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnbguy commented 3 months ago

If the tests are in separate PR, please add the changelog entries before merging 🙂

rnbguy commented 3 months ago

Is there anything pending for this PR? otherwise, we can wrap it us by adding changelog entries :slightly_smiling_face: