cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 74 forks source link

tendermint: box headers in Misbehaviour message #1145

Closed mina86 closed 3 months ago

mina86 commented 3 months ago

Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow.

Fix that by Boxing each of the headers in the Misbehaviour message.


PR author checklist:

Reviewer checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.06%. Comparing base (987ec42) to head (83d3d52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1145 +/- ## ======================================= Coverage 64.06% 64.06% ======================================= Files 217 217 Lines 21049 21049 ======================================= Hits 13484 13484 Misses 7565 7565 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.